Bugfix/regex regression - Githubissues

cucumber / language-service

Cucumber Language Service

MIT License

12 stars 22 forks source link

Bugfix/regex regression #119

Closed mrkaiser closed 1 year ago

mrkaiser commented 1 year ago

🤔 What's changed?

⚡️ What's your motivation?

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
:bug: Bug fix (non-breaking change which fixes a defect)
:zap: New feature (non-breaking change which adds new behaviour)
:boom: Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[x] Users should know about my change
- [x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

mrkaiser commented 1 year ago

@aslakhellesoy This fixes the regression reported in cucumber/vscode#125

aslakhellesoy commented 1 year ago

Great. Please add a test that would have failed before this change, and passes with it.

mrkaiser commented 1 year ago

@aslakhellesoy apologies for the delay i have added a pythonLanguage.test.ts file