search

cucumber / polyglot-release

Make polyglot releases with a single command
MIT License
5 stars 1 forks source link

Add a `--git-tag` option #58

Closed aslakhellesoy closed 2 years ago

aslakhellesoy commented 2 years ago

🤔 What's the problem you're trying to solve?

Use a release workflow where the git tag is created locally rather than in the GitHub Action. This would support the new "push a tag to trigger a release" workflow we have discussed.

✨ What's your proposed solution?

Create and push git tag if --git-tag is specified. The format of the tag would be v$NEW_VERSION. I think we should create a signed tag:

git tag -s "v$NEW_VERSION" -m 'Release v$NEW_VERSION'

This will fail if the user hasn't configured their signing key, but I think that's fine. They should.

📚 Any additional context?

We're using "trigger by tag push" in cucumber/vscode because we had to use a 3rd party Action to be able to upload release assets, and this action expects to find the git tag in ${{ github.ref_name }}

mpkorstanje commented 2 years ago

This would support the new "push a tag to trigger a release" workflow we have discussed.

I'm a bit confused. That's what we do.

https://github.com/cucumber/polyglot-release/blob/a97a81aad6abccd2b5bc6f14a67c61d9fc4a0fbd/polyglot-release#L373-L378

aslakhellesoy commented 2 years ago

Ohhhh I wasn't aware. Great! Closing this then.