cucumber / polyglot-release

Make polyglot releases with a single command
MIT License
5 stars 1 forks source link

Cannot release version after pre-release #98

Open luke-hill opened 11 months ago

luke-hill commented 11 months ago

👓 What did you see?

[15:41:39] luke@luke-ubuntu:~/Code/cucumber-rails$ polyglot-release 3.0.0
Version 3.0.0 has already been released.

✅ What did you expect to see?

polyglot-release working for cucumber-rails (3.0.0.rc1 is released)

📦 Which tool/library version are you using?

polyglot-release latest

🔬 How could we reproduce it?

Try run polyglot-release

Steps to reproduce the behavior:

  1. Install '...' version '...'
  2. Create a file called '....'
  3. Run command '....'
  4. See error '....'

📚 Any additional context?


This text was originally generated from a template, then edited by hand. You can modify the template here.

mpkorstanje commented 11 months ago

I suspect this check https://github.com/cucumber/polyglot-release/blob/51c37ccf5912c38f952ede8ba4b2bb6447f22757/polyglot-release#L287-L290 also matched the 3.0.0-rc1 tag.

mpkorstanje commented 11 months ago

No. It does not.

mpkorstanje@nyx:~/Projects/cucumber/cucumber-jvm$ git tag --list  | head
v1.0.0
v1.0.0-RC3
v1.0.0.RC1
v1.0.0.RC10
v1.0.0.RC11
v1.0.0.RC12
v1.0.0.RC13
v1.0.0.RC14
v1.0.0.RC15
v1.0.0.RC16
mpkorstanje@nyx:~/Projects/cucumber/cucumber-jvm$ git tag --list  v1.0.0
v1.0.0

@luke-hill could you check this with your git version?

Otherwise the only alternative I can think of is that you already had a 3.0.0 tag locally. And that you've deleted it when creating the latest release manually.

luke-hill commented 11 months ago

That didn't show that tag.

But I did the manual release like you showed me before. Making the changelog commit and version commit by hand, then pushing to main then making a new branch and pushing to that one.