search

cucumber / vscode

Official Visual Studio Code Extension for Cucumber
MIT License
65 stars 16 forks source link

Prevent Renovate autoupdating VSCode compatibility versions #191

Closed kieran-ryan closed 9 months ago

kieran-ryan commented 9 months ago

🤔 What's changed?

Configures Renovate to prevent automerging changes to the VSCode engine compatibility version - to prevent breaking compatibility; and to restore the version to its correct and previous version.

⚡️ What's your motivation?

Fixes #190.

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

CHANGELOG has not been updated, as changes were made since the latest release and only affect development builds since. However, please outline if should be updated.

Chose to allow Renovate to continue detecting vscode versions, but to prevent automerge. Alternatively, the VSCode versions could be ignored altogether through the configuration. Please advise whether the latter would be preferential; or whether other changes should be made to configuration.

📋 Checklist:

kieran-ryan commented 9 months ago

Appreciate the review @mpkorstanje, let me know if anything else to consider.

Based on the issue I raised with Renovate, disabling automerge appears the appropriate solution; however, I would be interested going forward to understand what causes Renovate to update the VSCode constraint version - assumption is a "major" release - will continue to follow up on that in the Renovate issue.

mpkorstanje commented 9 months ago

We can disable auto merge for majors. I see that Aslak enabled at the projects inception. I reckon that was done to speed things up (given the limited amount of time).

mpkorstanje commented 9 months ago

Edit: "the project" is vscode.

mpkorstanje commented 9 months ago

Removed the automerge for major versions in this PR.