search

cudadog / pydot

Automatically exported from code.google.com/p/pydot
MIT License
0 stars 0 forks source link

Parameters in parse actions #53

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is not really a bug, just a proposal: to facilitate migration to Python 3 
it would be better to change the parameter names of the "push_*" functions in 
"dot_parser.py" from "str" to "s" or "string".

Under Python 3 "isinstance(x, basestring)" becomes "isinstance(x, str)", which 
is not working when there is a local variable or parameter with the name "str". 
Thanks.

Btw. this is not even working in the Python 3 branch of pydot.

Original issue reported on code.google.com by pebo...@gmail.com on 4 Aug 2011 at 10:06

GoogleCodeExporter commented 9 years ago 
There are a few other things that could be done with respect to migration... I 
would be willing to adapt the code so that it runs under Python 2 and 3, if 
developers here are interested. I don't think a branch is necessary, and with 
support for both version the Python 3 version is always up-to-date.

Original comment by pebo...@gmail.com on 4 Aug 2011 at 10:28

GoogleCodeExporter commented 9 years ago 
Ack. Will look into the Python 3 pydot code.

Original comment by ero.carr...@gmail.com on 13 Dec 2011 at 11:29