cudeso / misp2sentinel

MISP to Sentinel integration
MIT License
60 stars 20 forks source link

Config.py file issues #105

Closed rijafida closed 5 days ago

rijafida commented 2 months ago

Screenshot 2024-09-11 130102

We have tried implementing this guide but there is a lot of confusion regarding the flow of the steps. in the screenshot attached the 3rd point highlights adding value for tenant. What value is that / is it the code right below it with the values replaced to reflect our environment?

Then the changes suggested to config.py file we assume here is the azure function. We need to make changes to the config.py file in the azure function?

Also do you have any documentation that deals with Graph method and Upload Indicator method separately. Everything is crammed into one article which makes it kind of hard to follow. This would really help us out Thanks.

cseelhoff-ms commented 1 week ago

the example json in the readme did not work for me either. try this format instead:

{
    "<TENANT_ID_WITH_APP_1>": {
      "id": "<APP_ID>",
      "secret": "<APP_SECRET>",
      "workspaceid": "<WORKSPACE_ID>"
    },
    "<TENANT_ID_WITH_APP_N>": {
      "id": "<APP_ID>",
      "secret": "<APP_SECRET_N>",
      "workspaceid": "<WORKSPACE_ID_N>"
    }
}
rijafida commented 1 week ago

We did try these changes based on some hit and trial and it worked ! 👍

cudeso commented 5 days ago

Updated example JSON with https://github.com/cudeso/misp2sentinel/commit/e57c84ab83d6177288ec41417fadbbe3df0ee285 based on feedback @cseelhoff-ms