search

cudeso / misp2sentinel

MISP to Sentinel integration
MIT License
52 stars 17 forks source link

Ensure the AzureFunction and "fat" Python script are in sync #79

Open cudeso opened 4 months ago

cudeso commented 4 months ago

There's a difference between the AzureFunction and the "fat" Python app installed locally.

Need to find ways on how to keep both in sync.

I'm focussed on the Python app locally, but open to ideas from @Kaloszer @lnfernux @jusso-dev

Kaloszer commented 4 months ago
  1. For logging just have a custom function that takes 'environment' flag - that has either local/azurefunction as a param and depending on that do console.log/context.log
  2. Merge both functions to keep the logic from both, I believe it was mentioned that the local one has the old method, but no reason to drop it if it hadn't been removed/deprecated yet.
  3. The local function can then just be a script reference to the 'merged' one from the azure function with the 'local' switch, default value of the switch would be azurefunction

PS: I'm quite busy at work at the moment and don't have much time, but hope that it will change, at least for the better in a couple of weeks :)

lnfernux commented 4 months ago

Same situation as @Kaloszer

I think 1. is a good idea, same with 2. as long as we are able to do that.