search

cue-lang / cue

The home of the CUE language! Validate and define text-based and dynamic configuration
https://cuelang.org
Apache License 2.0
5.14k stars 294 forks source link

Gerrit should have a "XXX" submit requirement #1959

Open mvdan opened 2 years ago

mvdan commented 2 years ago

See https://review.gerrithub.io/c/cue-unity/unity/+/543960/comments/ca065ef1_d81bfe3f. Right now, if a Gerrit CL's commit message contains "DO NOT REVIEW" or "DO NOT SUBMIT", the CL cannot be submitted.

However, we don't have anything equivalent for the changes made to files. Paul says that Google have a convention of "XXX" to mean something that must be resolved before a change is merged, akin to a TODO that cannot be left for later.

That sounds useful - we should add it.

myitcv commented 2 years ago

cc @mpvl to confirm XXX is indeed the "trigger" text for this.

leoluk commented 1 year ago

Gerrit already has a "Hold +1" label to block submission, perhaps that would be a better convention?

IIRC, you can't match on CL contents using submit requirements, so it'd have to be the CI doing it?

myitcv commented 1 year ago

IIRC, you can't match on CL contents using submit requirements, so it'd have to be the CI doing it?

I think this is possible via https://gerrit-review.googlesource.com/Documentation/config-submit-requirements.html#operator_file