cue-lang / cue

The home of the CUE language! Validate and define text-based and dynamic configuration
https://cuelang.org
Apache License 2.0
5.15k stars 296 forks source link

cuelang.org: modules reference has at least one 404 link #3542

Open mvdan opened 3 weeks ago

mvdan commented 3 weeks ago

What page were you looking at?

https://cuelang.org/docs/reference/modules/

What version of the site were you looking at?

https://github.com/cue-lang/cuelang.org/commit/74a384fdff6e70dcc7cb17c824793892cf95ba4a

What did you do?

Click on the "Build constraints" link in https://cuelang.org/docs/reference/modules/#resolve-pkg-mod.

What did you expect?

To be taken to some other doc page.

What did you see instead?

https://cuelang.org/pkg/go/build/#hdr-Build_Constraints, which is a 404, and probably inherited from Go without being fixed/tweaked accordingly.

Note that we do have https://pkg.go.dev/cuelang.org/go/cue/build, but it doesn't document build constraints in any way.

There may be other 404 links, but I couldn't quickly spot any.

mvdan commented 3 weeks ago

Worth noting that this is the only relative link to /pkg, so we likely want to make it absolute, because we don't render Go API docs ourselves:

$ git grep -E '\]\(/pkg'
reference/modules/en.md:constraints](/pkg/go/build/#hdr-Build_Constraints) are not applied for this