all: prepare for import into GerritHub

cue-unity / unity

unity - run experiments/regression tests on CUE modules

Apache License 2.0

41 stars 5 forks source link

all: prepare for import into GerritHub #97

Closed myitcv closed 2 years ago

myitcv commented 2 years ago

(see commit message)

myitcv commented 2 years ago

FWIW I thought that having CUE itself as a go.mod dependency would be okay, but removing it sounds good if we don't actually need to import any Go packages right now.

No, you're earlier comment is entirely spot on. We do import cuelang.org/go/..., so combining the two makes total sense.

myitcv commented 2 years ago

Rebase-merging this one PR and will close the others

mvdan commented 2 years ago

your earlier comment is entirely spot on

perhaps confusingly, you replied to a much older review here :) 19 days ago I thought this was OK, but just last week I commented that I thought it wasn't a good change, after a second look.