cuedo / github-webhooks

Haskell types and instances for decoding GitHub webhook payloads.
https://hackage.haskell.org/package/github-webhooks
MIT License
34 stars 15 forks source link

Handle when issue.body is `null` #30

Closed rob-b closed 4 years ago

rob-b commented 4 years ago

Handle parsing the case where issue.body is null. Make the field be optional but default to an empty string

Issue reference:

Submission Checklist:

rob-b commented 4 years ago

This is pretty much the same issue as my previous pr - there's a text field that github doesn't document can be null

kvanbere commented 4 years ago

Thanks, looks good. This is non breaking so I’m happy to merge this right away.

kvanbere commented 4 years ago

Are you fine if I release this soon? Do you see any other changes on the horizon?

rob-b commented 4 years ago

I've not encountered anything else that is likely to require any changes so please do go ahead and make a new release. Thanks for the quick turnaround