cuedpc / edpcmentoring

An experimental webapp for administering the EDPC mentoring scheme
MIT License
2 stars 1 forks source link

Sms67 mws3 #19

Closed S-Stephen closed 8 years ago

S-Stephen commented 8 years ago

I've added a Python script to help the installation of the application onto the university's MWS3 service.

Included the import of a settings_local file (not to be checked in) in the settings.py

Produced a requirements.txt file for the MWS3 service

I imagine that this script needs moving into a script directory or similar at some point. The script;

installs a virtual env installs the required dependencies produces the .htacces file copies the wsgi.py file into position and produces a settings_local.py file

For some reason the application will not run without DEBUG=True (settings_local.py file). This obviously needs fixing but I've been unable to resolve atm

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 85.356% when pulling 55e626d5398491aa8296993e01584d8198fb9147 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

rjw57 commented 8 years ago

Looks broadly OK to me although I'd like the setup_mws3.py somewhere other than top-level. Perhaps a deploy directory?

Since the MWS3-specific WSGI script exists, you might as well get it to specify a MWS-specific settings.py like the following:

from edpcmentoring.settings import *

# Perform any MWS-specific overrides here
SECRET_KEY=# ... etc, etc

This avoids the try:/except NameError: dance in settings.py which is a little convoluted.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling a6da5585e0db38eabeb69f665bfbdbb78e04c4d8 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling a6da5585e0db38eabeb69f665bfbdbb78e04c4d8 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling a6da5585e0db38eabeb69f665bfbdbb78e04c4d8 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling e3dc8c81cbd647b34f772a9d23ac348743db505c on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling fea59039bf2c7b85d29409a5d9132e3113007cdf on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling d118280d70265db98507db08315e4cb1433bb30b on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling d118280d70265db98507db08315e4cb1433bb30b on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling d118280d70265db98507db08315e4cb1433bb30b on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling 6166f32f22a1fa23b5cef3209276e7a9b8e66506 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling 6166f32f22a1fa23b5cef3209276e7a9b8e66506 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling 6166f32f22a1fa23b5cef3209276e7a9b8e66506 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling d31d5f5f57a7a1f353841a8adbda4d738eeca3e8 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling d31d5f5f57a7a1f353841a8adbda4d738eeca3e8 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling d31d5f5f57a7a1f353841a8adbda4d738eeca3e8 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling d8394ced2b8b00460999b406d973488bb192a495 on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling f3df8d6982ac9139c694282e600a51a5afce118e on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 85.154% when pulling f3df8d6982ac9139c694282e600a51a5afce118e on sms67-mws3 into dbaad6f025d0cc89098478bb2d9f87eebbb418fb on master.

S-Stephen commented 8 years ago

I hope to action the pythonish stuff next week

rjw57 commented 8 years ago

Now it's fairly self-contained I'm happy to merge as is and let style improvements in setup_mws3.py happen in a separate PR.