search

cueglow / glowdtf

Tech Demo for Controlling GDTF Lights over Art-Net
MIT License
8 stars 0 forks source link

JSON API Redesign #35

Closed Firionus closed 3 years ago

Firionus commented 3 years ago

This branch was branched off from feature/api, so we should merge that one in #32 before merging this one.

The new JSON API is more consistent and symmetrical between client and server. It is documented in /dev-docs/Client-Server API.md.

The new design gets rid of the GlowData class, instead moving to class polymorphism on GlowMessage to enable us to switch between arrays and objects for the data field. All JSON-related code is now in the json package.

Integration Tests with the Subscription API are not implemented here, as Subscription mechanism will be implemented in later PRs.

closes #28

Firionus commented 3 years ago

Rebased branch onto master after merging #32

Firionus commented 3 years ago

@DorianSnowball do you want to review this over the next week? Otherwise I'll review myself and merge.

The chain of dependent PRs is getting too long. It'll already be hard to make changes to any of the PRs that are currently open because the rebase of the following PRs will get complicated. We need to make some changes to the process, because as long as I'm the only one contributing code I don't see why I should deal with complex rebases and merges.