Closed wboykinm closed 8 years ago
Hmmmm . . . I stand corrected. Looks like turf.destination
barfed.
@wboykinm nice work! Glad to see this wasn't too big of a headache. Once we get things moving in browserify-land using the modules will be even easier.
Looks like the destination algorithm has changed every so slightly that our expected fixtures are now off by negligible distances. Updating the expected feature collection will get those tests passing!
var expectedOutput = {"type":"FeatureCollection","features": [
{"type":"Feature","properties":{"name":"Dinagat Islands"},"geometry":{"type":"Point","coordinates":[126.61573747959454, 10.098445590759694]}},
{"type":"Feature","properties":{"name":"Some other islands"},"geometry":{"type":"Point","coordinates":[131.03526863385326, 14.997661774321049]}}
]};
@mapsam Thanks - that did the trick!
update output FC coordinates by the length that a fingernail grows in 3s
😆
Codeship doesn't like to work on forks, which is a bummer. Last thing @wboykinm is to update the version in dropchop.js
to 0.2.2
and this will be 👍
@mapsam Should be all set now.
Boom!
By some miracle, dropchop was not using any of the modules that changed name and/or params between turf v2 and v3. As such this was a simple update to address #255.
Claiming a low-hanging fruit here and moving on, because switching to modularized turf dependencies - per @mapsam's suggestion - threw a few complex errors that'll need more work in #261.