cuikho210 / revelation-mobile-midi-to-mml

MIDI to MML converter and playback tool, powered by Rust and Flutter
MIT License
10 stars 6 forks source link

messy pacing bugs #18

Open YudhaPratamaPutra opened 2 months ago

YudhaPratamaPutra commented 2 months ago

Please don't combine the melody track with the accompanying song track, in the previous version the MML results were quite good, but it just couldn't play like in the latest version and in the Firebird song the tempo was messy because the song has many different tempos 😅 I hope the Firebird song can be included in the Revelations game perfectly, because I really like this song Midi.zip

cuikho210 commented 2 months ago

Hi, I created a branch to test it here: https://github.com/cuikho210/revelation-mobile-midi-to-mml/tree/optional-merge-meta-events

It seems that the issue is not related to sharing tempo between tracks but rather in the algorithm for converting MIDI events to MML events.
I suspect it's somewhere in here: https://github.com/cuikho210/revelation-mobile-midi-to-mml/blob/main/lib/src/parser/bridge_to_mml.rs 🥹🥹