Closed cuisongliu closed 2 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 36.31%. Comparing base (
d832db1
) to head (c362e0f
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request includes various improvements and fixes to the
automq_controller
and related test files to enhance logging, error handling, and test coverage. The most important changes include adding detailed error logs, updating test cases, and modifying the namespace for the tests.Error Handling and Logging Improvements:
internal/controller/automq_controller.go
: Added detailed error logs in multiple functions to provide more context when failures occur. [1] [2] [3] [4] [5]internal/controller/automq_controller_b.go
: Enhanced logging for PVC, service, and deployment creation failures. [1] [2] [3]internal/controller/automq_controller_c.go
: Improved logging for controller PVC, service, and deployment creation failures. [1] [2] [3]Test Case Updates:
e2e/automq_cluster_controller_test.go
: Updated the namespace name and added new test cases for resource creation, reconciliation, and status checks. [1] [2] [3]e2e/automq_cluster_test.go
: Set theNAMESPACE_NAME
environment variable in theBeforeSuite
function.Minor Code Enhancements:
internal/controller/automq_controller.go
: Added index logging in the reconcile loop for better traceability.e2e/automq_cluster_controller_test.go
: Added necessary imports for new test cases.internal/controller/automq_apis.go
: Added a blank line for better code readability..github/workflows/test.yml
: Added a command to get services in all namespaces to the testing workflow.