cuitao2046 / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Current SVN sources @r92 fails to build from source #235

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Compile google-perftools from SVN sources at r92 (the current head)

What is the expected output? What do you see instead?

The sources fail to compile. I've attached logfiles of the configure and 
compile output.

What version of the product are you using? On what operating system?

I'm using the current SVN sources at r92.
The machine is a Lucid Lynx Unbuntu x86_64 machine, uname -a gives: Linux 
xxxx 2.6.32-21-generic #32-Ubuntu SMP Fri Apr 16 08:09:38 UTC 2010 x86_64 
GNU/Linux
GCC on this machine is: gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3

Please provide any additional information below.

It looks like the problem is just a missing closing brace at 
tcmalloc.cc:901: http://code.google.com/p/google-
perftools/source/browse/trunk/src/tcmalloc.cc?spec=svn92&r=92#901

The following diff fixes things for me:

Index: src/tcmalloc.cc
===================================================================
--- src/tcmalloc.cc (revision 92)
+++ src/tcmalloc.cc (working copy)
@@ -898,6 +898,7 @@
     return true;
   }
   return false;
+}

 // Helper for do_malloc().
 inline void* do_malloc_pages(ThreadCache* heap, size_t size) {

Thanks,
acm

Original issue reported on code.google.com by andrew.c.morrow@gmail.com on 22 Apr 2010 at 3:44

Attachments:

GoogleCodeExporter commented 9 years ago
Oops, that's embarrassing...

I just checked into svn a fix for this, and for a few other issues that had 
come up 
(the pthread_once extern declaration was wrong, too).

Original comment by csilv...@gmail.com on 22 Apr 2010 at 5:32

GoogleCodeExporter commented 9 years ago
Everything builds fine now. Thanks for the quick fix.

Original comment by andrew.c.morrow@gmail.com on 22 Apr 2010 at 5:43