cuitao2046 / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Remove #include<vector> from heap-checker.h #337

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Including heap-checker.h in .c file 
2. Build it with GCC ( I cant modify the make-file to change compiler from gcc 
to g++)
3. You will get an error that #include <vector> not found

What version of the product are you using? On what operating system?
--> Ubuntu 10.10 and Custom Embedded Linux

Please provide any additional information below.
Ans. Please remove #include <vector> from heap-checker.h, because this requires 
to change library and create another header file with no c++ file included.

Original issue reported on code.google.com by sunny....@gmail.com on 27 May 2011 at 6:48

GoogleCodeExporter commented 9 years ago
heap-checker.h is C++ from beginning to end.  Removing <vector> isn't going to 
help you.

Why do you need to #include heap-checker.h in a .c file?  See 
malloc_extension_c.h/etc for how we've dealt with this for other provided 
header files.  Would you want to do such a thing for heap-checker.h?

Original comment by csilv...@gmail.com on 28 May 2011 at 12:06

GoogleCodeExporter commented 9 years ago
Sorry, I was dealing with multi-lanngauage compatibility first time, Yes having 
C extension for heap_checker can really help.

Original comment by sunny....@gmail.com on 28 May 2011 at 3:52

GoogleCodeExporter commented 9 years ago
OK, feel free to submit a patch!  Or we'll add it to the feature request queue, 
though I can't give a time estimate.

Original comment by csilv...@gmail.com on 31 May 2011 at 10:20

GoogleCodeExporter commented 9 years ago
Haven't heard anything in a while, so closing -- not to indicate we're opposed 
to the idea, just we don't plan to do it ourselves.  Feel free to reopen if 
(when) you have a patch to propose!  

Original comment by csilv...@gmail.com on 18 Oct 2011 at 6:21