search

cujojs / curl

curl.js is small, fast, extensible module loader that handles AMD, CommonJS Modules/1.1, CSS, HTML/text, and legacy scripts.
https://github.com/cujojs/curl/wiki
Other
1.88k stars 216 forks source link

dev08 - promise.yield is undefined #188

Closed phated closed 11 years ago

phated commented 11 years ago

This only happens when I have preloads defined.

It seems that promise.yield attempts to be called on the promise object returned from new CurlApi() call for cfg.preloads. See lines https://github.com/cujojs/curl/blob/dev08/curl.js#L761-L778

Not sure what is supposed to be happening there.

phated commented 11 years ago

Oops, forgot to note that this only happens after a build with cram.

unscriptable commented 11 years ago

LOL. When I said check out the dev branch, I meant "dev", not "dev08". Although, i'd really like to be working on the dev08 branch, atm too! :)

I am sure there are lots of issues with the dev08 branch. It's the start of a 95% rewrite and doesn't even support plugins, yet (amongst other things).

Fwiw, I hit this same problem and fixed it, but haven't pushed it to github, yet.

Closing this issue. If you think we need to reopen it, please do. :)

phated commented 11 years ago

Oops! I actually got it building my custom plugin and the code looks like it would work. Anyway, really excited to see this rewrite, even if I just played with it briefly.