search

cujojs / curl

curl.js is small, fast, extensible module loader that handles AMD, CommonJS Modules/1.1, CSS, HTML/text, and legacy scripts.
https://github.com/cujojs/curl/wiki
Other
1.89k stars 216 forks source link

Limit of ieMaxCollectorSheets? #193

Closed exitmusic closed 11 years ago

exitmusic commented 11 years ago

Is the current limit of 11 collector sheets somehow related to IE's 31 stylesheets limitation? https://github.com/cujojs/curl/blob/master/src/curl/plugin/css.js#L104

I set ieMaxCollectorSheets = 32 locally to quickly resolve an issue I experienced when exceeding the 11 limit, but was wondering if there are side effects to this I am missing.

unscriptable commented 11 years ago

What's the issue you were seeing? Do you actually have 4096 * 11 = 45056 css rules?

The ieMaxCollectorSheets is used to limit the number simultaneous downloads. Since IE8 and IE9 won't load more than 12 at a time, that seemed like a reasonable limit. I'm curious to understand what issue you saw and how lifting that limit fixed it. :)

exitmusic commented 11 years ago

Thanks for the explanation.

I'm actually using another plugin (require-css) that borrows logic from this one: https://github.com/guybedford/require-css/issues/77

A quick background. I have a project that defines many modules using require.js. Each module includes its own stylesheet using the css! plugin. I think the reason I hit the limit is because the plugin sees each stylesheet as a collector sheet in IE, which easily puts me over 11.

I'll spend some more time looking at creating parent stylesheets to avoid this issue.

unscriptable commented 11 years ago

curl.js's css! plugin should automatically create parent stylesheets for you. It works correctly in my tests, but maybe there's something special about your environment.

So you're using requirejs instead of curl.js? Maybe that's part of the difference. I don't test curl.js's plugins with requirejs.

I'm going to close this issue for now. Please reopen it if you decide to try curl.js again!

Regards,

-- John

exitmusic commented 11 years ago

Thanks!