search

cujojs / curl

curl.js is small, fast, extensible module loader that handles AMD, CommonJS Modules/1.1, CSS, HTML/text, and legacy scripts.
https://github.com/cujojs/curl/wiki
Other
1.89k stars 216 forks source link

Escaped single quotes in CommonJS modules are not #239

Closed unscriptable closed 10 years ago

unscriptable commented 10 years ago

Escaped single quotes (\') in CommonJS modules are not encoded properly, it seems. If they exist in the code, the browser rejects them with an error. Found the problem when using the injectScript:true option. (edit: it seems to happen in the default mode, too.)

unscriptable commented 10 years ago

Also: it converts a regexp like this: /\/+$/ to this: //+$/ (a comment!).

unscriptable commented 10 years ago

Closing. This was not a cram.js issue.