Improve the checking of subscriber objects to match RxJS and zen-observable (#445)

cujojs / most

Ultra-high performance reactive programming

MIT License

3.49k stars 231 forks source link

Improve the checking of subscriber objects to match RxJS and zen-observable (#445) #448

Closed far-blue closed 7 years ago

far-blue commented 7 years ago

Summary

Use object wrapping rather than the typeof check to determine if subscriber is valid. Correctly handles objects and functions and is compatible with how RxJS and zen-observable behave as they don’t distinguish between objects and functions. (issue #445)

briancavalier commented 7 years ago

Great thanks @far-blue! Could you add a test here that covers the function case?