search

cujojs / most

Ultra-high performance reactive programming
MIT License
3.49k stars 231 forks source link

test performance upgrade #523

Open cortopy opened 6 years ago

cortopy commented 6 years ago

Summary

New performance tests are in!! Major changes:

Todo

Compare most.js with the latest versions of other reactive frameworks

briancavalier commented 6 years ago

Thanks, @cortopy! I should have time to look at this over the weekend.

briancavalier commented 6 years ago

Quick, question about how you ran these.

It's best to run them with as little else running on the machine as possible. There's really no way to get a "perfect" run (whatever that might mean), of course, but at least on OS X I've seen some weird outliers when I've forgotten to quit everything but a terminal window.

So, if you did that, great! This looks ready to merge. If not, would you mind doing another run? Thanks!

Also, if you're up for it, I'd be delighted to have a similar PR over at mostjs/core.

cortopy commented 6 years ago

I did close all windows for the reasons mentioned. But that's a good point. I'll try again by restarting my computer in terminal mode

briancavalier commented 6 years ago

Thanks, @cortopy, I appreciate the extra effort. I've not actually booted into console mode to do it, but usually quit all user apps. It'll be kinda cool to see what differences dropping to console mode reveals!

cortopy commented 6 years ago

@briancavalier interestingly, not much of a difference in terminal mode. I've done a new commit with the results

briancavalier commented 6 years ago

Awesome, thanks @cortopy. Now we know :). I guess operating systems (perhaps particularly linux) have gotten pretty good at not using resources when idle.

I'll give the code another close look before merging.