search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

RequireJS Issues with 3.0.1 #283

Closed jefflage closed 10 years ago

jefflage commented 10 years ago

i just bumped our bower.json to from 2.8 to 3.0.1 and I'm getting errors. its coming from the require() statements within when.js:

var timer = require('./lib/timer');

RequireJS is taking that relative path not form the location of when.js rather from the baseUrl in our require.config so the files are not found. has anyone else encountered this since upgrading?

briancavalier commented 10 years ago

Hey @jefflage. Hmmm, I haven't seen this problem. Could it be that you've configured RequireJS using a path instead of a package? If so, could you try a package, see here in the installation docs. Let me know!

jefflage commented 10 years ago

as always, you’re spot on. we were loading it using a path not a package so i guess when i read over this my mind meshed the two. its working great. thanks.

Jeffrey A. Lage
86 Hart St | Beverly Farms | MA | 01915 | email: jefflage@me.com | iPhone: 551.689.4867

On Mar 28, 2014, at 9:18 AM, Brian Cavalier notifications@github.com wrote:

Hey @jefflage. Hmmm, I haven't seen this problem. Could it be that you've configured RequireJS using a path instead of a package? If so, could you try a package, see here in the installation docs. Let me know!

— Reply to this email directly or view it on GitHub.

briancavalier commented 10 years ago

Cool, glad that helped!