cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Deprecate when.some #288

Closed briancavalier closed 10 years ago

briancavalier commented 10 years ago

Does anyone actually use this in practice? It seems useful at first glance, but honestly, I can't think of the last time I actually used it. So I figured I'd open this up for discussion.

I guess we have some options:

  1. Keep it as is. If people are using it, obviously this is the right choice. But if no one's using it, why keep it?
  2. Move it out of the core when module so that it becomes a la cart. Could be a good option if it's used, but rarely.
  3. Remove it. Again, if it's yagni, why keep it?

Options 2 & 3 are both breaking changes. For option 2, we could move it, provide a deprecated backcompat shim as when.some, then remove that shim in 4.0 . For option 3, we'd deprecate when.some directly now, then remove in 4.0

briancavalier commented 10 years ago

Deprecated for 3.2.0