promise returned from promise.finally does not resolve

[jescalan]

If you return a promise from promise.finally, it is not given a chance to resolve, and finally returns as if synchronous. Example:

somePromise.finally(function(){
  console.log('running finally');
  otherPromise().tap(console.log); // this does not execute
}).tap(function(){ console.log('done with promise chain'); });

[briancavalier]

Great, thanks for the example! One minor correction, it needs a return:

somePromise.finally(function(){
  console.log('running finally');
  // added return
  return otherPromise().tap(console.log); // this does not execute
}).tap(function(){ console.log('done with promise chain'); });

Working on a fix now!

[jescalan]

:tada:

Ah I'm sorry, too much coffeescript with implicit returns

[briancavalier]

No worries, I figured it was coffeescript ;)