cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Move when/poll to separate package #374

Closed briancavalier closed 9 years ago

briancavalier commented 9 years ago

It seems like a less-often used feature. Should we move it to its own when-poll package for 4.0?

scothis commented 9 years ago

What's old is new again. ;)

No objection if you think reducing the side of the when package is worth adding a dependency for those who use poll.

briancavalier commented 9 years ago

What's old is new again. ;)

Haha, I know right?

I'm not really sure what's best, so I just wanted to bring it up for discussion.

Last time we went down this road, we may have been thinking too coarse grained, ie one "contrib" bucket where "everything else" would go. Lately I've been thinking that smaller, focused a la carte add-ons, like when-poll or those dealing with a particular "topic", like most-w3msg are a good direction.

mikaelkaron commented 9 years ago

That would be most awesome.

On 2 Oct 2014, at 20:25, Brian Cavalier notifications@github.com wrote:

What's old is new again. ;)

Haha, I know right?

I'm not really sure what's best, so I just wanted to bring it up for discussion.

Last time we went down this road, we may have been thinking too coarse grained, ie one "contrib" bucket where "everything else" would go. Lately I've been thinking that smaller, focused a la carte add-ons, like when-poll or those dealing with a particular "topic", like most-w3msg are a good direction.

— Reply to this email directly or view it on GitHub.

mikaelkaron commented 9 years ago

Would it make sense to create a list of features that could be externalized as their own modules? Since I'm a consume of at least three of these (poll/unfold/iterate) I'd be happy to help out.

briancavalier commented 9 years ago

@mikaelkaron That sounds like a great idea. I think we could consolidate into a single github issue and discuss there until we converge on a list, and the right number of external packages.

briancavalier commented 9 years ago

See #377

briancavalier commented 9 years ago

Closing in favor of #377