search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Add example of supporting both promises and node-style callbacks. #409

Closed jamlen closed 9 years ago

jamlen commented 9 years ago

PR for #408, hope my wording is OK!

briancavalier commented 9 years ago

Thanks @jamlen! Looks great. I only had a couple minor suggestions.

jamlen commented 9 years ago

I'm not sure about the "Combo Api", just because I prefer it being really obvious and when I was looking for this as an example I would not necessarily have thought of looking at "Combo Api", whereas "Support Promises and Node-style Callback" is hard to miss or skip over!

briancavalier commented 9 years ago

:+1: Obvious is good. Let's go with your original heading.

jamlen commented 9 years ago

OK updated to remove the superfluous the.

jamlen commented 9 years ago

I can't see that this has broken the build!

briancavalier commented 9 years ago

@jamlen No worries, it looks like a spurious failure ... we see that sometimes with Travis + Sauce Labs. I restarted the build--I can't imagine how a docs change would break the build :)

Everything looks good. I'll merge it once Travis goes green!

briancavalier commented 9 years ago

Thanks again, @jamlen.