search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Avoid inter-lib, recursive nextTick warning on node 0.10 #411

Closed briancavalier closed 9 years ago

briancavalier commented 9 years ago

See #410

Use setImmediate on node 0.10 to avoid hitting its max nested tick limit warning.

We've not had any direct reports from a when.js user who has encountered this. However, the test case from RSVP is generic, so it's pretty clear that this could happen to any set of interleaving promise libs.

It's a shame that this requires a version check :(

cc @stefanpenner

Fix #410

stefanpenner commented 9 years ago

We've not had any direct reports from a when.js user who has encountered this.

Ya, the scenario for us is pretty specific, but it happens. :(

It's a shame that this requires a version check :(

Ya :( it's even sadder since it has been "fixed" for over a year, but node-stable is still doesn't include it.

briancavalier commented 9 years ago

Interesting that this is breaking on iOS 6 ... not sure why yet, tho.

briancavalier commented 9 years ago

Bluebird has since backed this change out. Seems like we should just abandon this.

stefanpenner commented 9 years ago

ya, node 0.10 is now replaced with node .12, which doesn't have this issue

briancavalier commented 9 years ago

@stefanpenner Thanks!