search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

when.js + webpack + sinon.useFakeTimers() #449

Closed KidkArolis closed 9 years ago

KidkArolis commented 9 years ago

I'm running into this issue https://github.com/webpack/node-libs-browser/issues/20

Do you think the isNode() detection could be improved in when.js somehow so that Mutation Observers are used even if webpack injects a fake window.process?

On the other hand, this would only fix this issue for modern browsers..

KidkArolis commented 9 years ago

Ok. Actually. I think it's all fine now. :-S

KidkArolis commented 9 years ago

Oh well.

KidkArolis commented 9 years ago

Nope, the issue is back.

KidkArolis commented 9 years ago

This is how bluebird does the isNode check https://github.com/petkaantonov/bluebird/blob/master/src/util.js#L284-L285

briancavalier commented 9 years ago

Heh, thanks @KidkArolis. I should have time to look into this over the weekend.