search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Switch isNode check to avoid problem with webpack #450

Closed briancavalier closed 9 years ago

briancavalier commented 9 years ago

This should fix recently introduced incompatibility in webpack.

cc @KidkArolis

Fix #449

briancavalier commented 9 years ago

@KidkArolis could you try out the improve-isnode-check branch and let me know if it fixes the issue for you? Thanks!

KidkArolis commented 9 years ago

Yes, this does seem to fix the issue!

The issue was a bit sporadic, but doing var clock = sinon.useFakeTimers(); clock.restore();without ever callingclock.tick()` would seem to always hang all promises after that. But it all works fine with this branch.

briancavalier commented 9 years ago

Awesome, thanks for confirming. I'll merge and release asap :)