search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Add implementation for keys.settle #463

Closed anthonyvia closed 9 years ago

briancavalier commented 9 years ago

Hey, thanks, @anthonyvia! I'll take a look at this tomorrow. The travis failure may be a spurious saucelabs error that we see occasionally. I restarted it, so we'll see. I really appreciate that you took the time to include docs and tests.

briancavalier commented 9 years ago

Cool, thanks for updating this, @anthonyvia. I just had one comment about the deep indentation. After that, I think this will be ready to merge!

anthonyvia commented 9 years ago

Thanks for the review @briancavalier and @campersau! I've pushed my changes.

briancavalier commented 9 years ago

Thanks again for this contribution, @anthonyvia!