search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Do not use git in package.json #470

Closed artem-malko closed 8 years ago

artem-malko commented 8 years ago

Hi. Is it possible to not use git here: https://github.com/cujojs/when/blob/master/package.json#L60 It is a problem, cause I can't install this package without git in my OS.

briancavalier commented 8 years ago

Hey @artem-malko, yeah, now that poly is published to npm, we could switch to that. I'll try it out in a branch soon.

Poly is only used for unit testing when.js in browsers (on saucelabs). Is it an option for you to npm install --production in the mean time?

artem-malko commented 8 years ago

@briancavalier hi! No, I can't do it, cause when is used as dep in gulp-less and gulp-stylus. So, I'll be waiting for new release. Thank you.

briancavalier commented 8 years ago

@artem-malko Understood, thanks for clarifying. I should have time to send a PR for this tonight.

artem-malko commented 8 years ago

@briancavalier could you write to me (or just write here) after all work has been done?

briancavalier commented 8 years ago

Sure, I'll ping you in the PR so you can follow it.

artem-malko commented 8 years ago

Thank you a lot)

briancavalier commented 8 years ago

@artem-malko I just published 3.7.4 which includes this change. I hope it helps!

artem-malko commented 8 years ago

@briancavalier it is really helpful)