search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 394 forks source link

Issue with browserify #477

Closed Kyos closed 8 years ago

Kyos commented 8 years ago

What's this PR purpose?

When you try to browserify a file which require when, you get this error : 

Error: Cannot find module '../when' from '/Users/olivierlaniesse/src/iadvize/test/node_modules/when/dist/browser'
    at /Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:55:21
    at load (/Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
    at /Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:99:15)

This PR aims to fix it :smiley:

Step to reproduce

  1. npm install --save when browserify
  2. Edit a js file with this code (aka : test.js) :
require('when')
  1. run : browserify test.js
  2. Read the error :)

    Environnement

    • npm v2.14.11
    • when 3.7.6
briancavalier commented 8 years ago

Reproduced! Thank you for the level of detail, and for the fix, @Kyos :)

briancavalier commented 8 years ago

Just published 3.7.7 with this fix. Thanks again!