search

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.
Other
3.44k stars 396 forks source link

Correct promise.tap "equivalent" explanation #480

Closed stevage closed 8 years ago

stevage commented 8 years ago

I'm far from certain about this, but I don't think the "equivalent" JS code for promise.tap was correct.

According to the description of the function, promise.tap should wait for doSideEffectsHere's return, and should reject if doSideEffectsHere() returns a rejected promise. Which the "equivalent" code didn't achieve. I think.

briancavalier commented 8 years ago

Thanks!