Fix unhandled rejection warnings in when.settle (#493)

cujojs / when

A solid, fast Promises/A+ and when() implementation, plus other async goodies.

Other

3.44k stars 396 forks source link

Fix unhandled rejection warnings in when.settle (#493) #494

Closed rkaw92 closed 7 years ago

rkaw92 commented 7 years ago

Fix unhandled rejection warnings that resulted from creating superfluous Thenables during optimizations in settleOne() when working with foreign Promise objects

briancavalier commented 7 years ago

Thank you, @rkaw92. I'll make time to look at this in the next couple days.

briancavalier commented 7 years ago

Looks good. I restarted the travis job to see if the failure was just a spurious saucelabs hiccup (which happens, unfortunately).

briancavalier commented 7 years ago

I see the issue. Saucelabs no longer supports one of the platforms we're running the tests on. Here's the error in the travis log. I think we can merge this, and then remove that platform from the sauce config in another commit.

Thanks again!