search

cujojs / wire

A light, fast, flexible Javascript IOC container
Other
862 stars 71 forks source link

wire/builder/cram chokes on urls that include a protocol #147

Closed unscriptable closed 10 years ago

unscriptable commented 10 years ago

Any instances of "//" are interpreted as comments and the remainder of the line is removed. For instance, this:

apiClient: { $ref: 'client!http://www.example.com' }

ends up as this:

apiClient: { $ref: 'client!http:
unscriptable commented 10 years ago

This is a hackish work-around for now:

apiClient: { $ref: 'client!http:/' + '/www.example.com' }
unscriptable commented 10 years ago

Posted a fix in dev at https://github.com/cujojs/wire/commit/7279d956b540653ba47f9a46d05db10767276972

briancavalier commented 10 years ago

:+1: We should get a release together, since this is a pretty important fix.