search

cujojs / wire

A light, fast, flexible Javascript IOC container
Other
862 stars 71 forks source link

Wire does not work with 'when' 3.0.0. #155

Closed jimkang closed 10 years ago

jimkang commented 10 years ago

Wire does not work with version 3.0.0 of the when module. It instantiates dependencies with the wrong arguments. However, it works fine with when 2.8.0.

Wire's package.json specifies the dependency in package.json like so:

"when": ">=1.5.0 || ~2"

This means that when you currently run npm install, it will use when 3.0.0 instead of a 2.x version.

briancavalier commented 10 years ago

Hey @jimkang, thanks for the heads up! We were aware of the incompatibility (an update is coming soon), but thought the semver in package.json would do the right thing :( Sorry about that! I'll push an update asap that limits the when version to 2.x.

jimkang commented 10 years ago

@briancavalier Thanks for the fix!

briancavalier commented 10 years ago

No prob, thanks again for reporting this.