cujojs / wire

A light, fast, flexible Javascript IOC container
Other
862 stars 71 forks source link

Add when 3.0 compat #157

Closed briancavalier closed 10 years ago

briancavalier commented 10 years ago

There were a few breaking API changes in when 3.0 that make it incompatible with wire 0.10. It should be an easy update.

jeffrose commented 10 years ago

I am currently seeing an issue with using wire 010.6 and when 3.0.1. A wire spec that was once working with 0.10.5/2.8.0 has stopped. Here is a quick sample...

{
    appFoo: {
        create: 'foo'
    },
    fooFilter: {
        create: {
            module: 'fooFilter',
            args: {
                $ref: { 'appFoo' }
            }
        }
    },

    $plugins: [ { module: 'wire/debug', trace: true } ]
}

When appFoo is passed into fooFilter it has the value 5000, which of course is not correct. :-)

briancavalier commented 10 years ago

Hey @jeffeose, it's a known incompatibility. We're working on it. The bower.json indicates that you'll need 2.x, and we'll update that when we release a version that's compatible with when 3.0

briancavalier commented 10 years ago

@jeffrose Sorry my last comment sounded kind of gruff, and if my original post wasn't clear--I see now that the way I worded it could imply that wire 0.10.x, where x > 0, are compatible with when 3. Unfortunately, right now all versions of wire are incompatible with all versions when >= 3.0.0. We're targeting next week for a compatibility release.

Thanks for the nice, simple test case as well!

jeffrose commented 10 years ago

@briancavalier No problem. I did initially think that wire 0.10.6 was compatible with when 3.0.x, which is why I gave it a shot. Looking forward to updated release. :-)

briancavalier commented 10 years ago

Just released wire 0.10.7 which adds when 3.x compatibility. Feel free to open new github issues if you find any problems. Thanks!

unscriptable commented 10 years ago

woohoo :+1: