cul-2016 / quiz

11 stars 4 forks source link

[WIP] Individual lecturer #633

Closed jessicasalmon closed 6 years ago

jessicasalmon commented 6 years ago

PLEASE VIEW AND MERGE AFTER #632

codecov-io commented 6 years ago

Codecov Report

Merging #633 into staging will decrease coverage by <.01%. The diff coverage is 93.1%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging     #633      +/-   ##
===========================================
- Coverage    94.19%   94.18%   -0.01%     
===========================================
  Files          124      124              
  Lines         2791     2804      +13     
  Branches       481      487       +6     
===========================================
+ Hits          2629     2641      +12     
- Misses         162      163       +1
Impacted Files Coverage Δ
server/lib/getUserByEmail.js 100% <100%> (ø) :arrow_up:
server/plugins/super-admin.js 87.09% <100%> (+1.38%) :arrow_up:
server/lib/authentication/saveUser.js 100% <100%> (ø) :arrow_up:
server/plugins/authenticate-user.js 95.91% <100%> (+0.36%) :arrow_up:
server/plugins/strategy.js 88.88% <81.81%> (-4.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c32f445...1ba6b53. Read the comment docs.

Danwhy commented 6 years ago

Apart from covering that one line, looks good. Merging this one for now too (see https://github.com/cul-2016/quiz/pull/632#issuecomment-374035084)