Closed finnhodgkin closed 6 years ago
:warning: @finnhodgkin, the pull request is in "awaiting-review" but doesn't have a reviewer or a correct assignee. Please assign someone to review the pull request, thanks.
Any questions, complaints, feedback, contributions?
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
Just hasn't accepted the invitation yet 😊 @shouston3 Let me know if you need me to send it again!
@finnhodgkin, hoorah! 🎉 It's review time! 👀
I couldn't help but notice that there isn't an in-progress
label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔
To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄
Any questions, complaints, feedback, contributions?
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
@shouston3 - yep, you're seeing the right thing! We were focussing on functionality yesterday so it's pretty bare right now. Now that we've hooked up the db to Heroku I'll also be adding more content too.
I'm really glad it's bare, the smaller the prs the better. Looks great. I would say to keep focusing on functionality for now
Just received the heroku invite
@shouston3 - are you still in-review on this one?
Yes. If you have made progress and would like to make another pr, could you make another pr which builds on top of this branch and make that pull request into current master
I can't assign @shouston3 yet, guessing he hasn't been added to the org yet :cry:
Sorry this PR is rather large. Changes:
8 #7 #4