cul-it / archival-storage-ingest

Automated ingest application for CULAR archival storage
1 stars 0 forks source link

Refactored fixity workers. #12

Closed bb233 closed 5 years ago

bb233 commented 5 years ago

I have refactored the fixity workers to make the code between the S3 and SFS workers exist in a common class, and only S3/SFS-specific details are implemented in the individual classes.

To implement a new fixity worker type, you just need to implement the three methods:

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 72


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/archival_storage_ingest/workers/fixity_worker.rb 32 35 91.43%
<!-- Total: 34 37 91.89% -->
Totals Coverage Status
Change from base Build 67: -0.3%
Covered Lines: 826
Relevant Lines: 898

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 70


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/archival_storage_ingest/workers/fixity_worker.rb 32 35 91.43%
<!-- Total: 34 37 91.89% -->
Totals Coverage Status
Change from base Build 67: -0.3%
Covered Lines: 826
Relevant Lines: 898

💛 - Coveralls