Closed bb233 closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/archival_storage_ingest.rb | 9 | 12 | 75.0% | ||
lib/archival_storage_ingest/s3/s3_manager.rb | 1 | 4 | 25.0% | ||
<!-- | Total: | 88 | 94 | 93.62% | --> |
Totals | |
---|---|
Change from base Build 82: | 0.8% |
Covered Lines: | 910 |
Relevant Lines: | 999 |
When logging the status of the work done, I think it would be enough to just record the status and the ingest_id, rather than recording the status and the whole ingest message which we already have at the beginning of the work.
I've made that suggested change. Does it look good now? @sk274
This pull request
It also improves the testing of logging functionality.