coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 41
- 157 of 159 (98.74%) changed or added relevant lines in 7 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+2.8%) to 89.439%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/archival_storage_ingest/s3/s3_manager.rb | 1 | 2 | 50.0% | ||
| spec/compare_worker_spec.rb | 59 | 60 | 98.33% | ||
| <!-- | Total: | 157 | 159 | 98.74% | --> |
| Totals | |
|---|---|
| Change from base Build 36: | 2.8% |
| Covered Lines: | 669 |
| Relevant Lines: | 748 |
Add fixity-check worker. The code could use some clean-up, but all the tests pass and I believe the behavior is what we want.
I am not happy with how the s3_manager.retrieve_file() works, as it returns an IO object which may or may not be easy to work with. I'd like to rethink that interface at some point.