cul-it / cornell_marc_importer

Custom marcxml import mapping plugin for ArchivesSpace
0 stars 2 forks source link

logic for single or inclusive date on export #29

Closed starsplatter closed 6 years ago

starsplatter commented 6 years ago

aspace is doing

string += obj.level == 'item' && date['date_type'] == 'single' ? 's' : 'i'

which means if something like https://newcatalog.library.cornell.edu/catalog/8796928/librarian_view comes in as a collection it fails the logic and the date gets exported as inclusive instead of single.

so i'm not sure what the right behavior is here.

is the import as 'single' correct? if so should i override the export so that things marked as collection can be 'single'?

(if something like this shouldn't be a collection at all but a monograph, that would need to get changed in the original marc)

@e2d2

starsplatter commented 6 years ago

should be single