search

cul-it / exhibits-library-cornell-edu

Spotlight
3 stars 2 forks source link

[BUG] Full screen option does not bring up correct image on specific pages #594

Closed hudajkhan closed 1 year ago

hudajkhan commented 1 year ago

Describe the bug

For some images in an exhibit page, the full screen button is not bringing up the right image. On the same page further down, clicking on the full screen button does not bring up the full screen view.

To Reproduce

Steps to reproduce the behavior: 1.Go to https://exhibits.library.cornell.edu/social-fabric-land-labor-and-the-world-the-textile-industry-created/feature/industrialization

  1. Click on the full screen option for the item with the label "United States. Department of the Treasury. Alexander Hamilton's Famous Report on Manufactures Made to Congress in his Capacity as Secretary of the Treasury, 1892."

Expected behavior

The full screen should show the image itself and not a different image.

Actual behavior

An unrelated image displays when the user clicks the full screen option.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context

hudajkhan commented 1 year ago

The item in question is embedded using the embedded image viewer option. The item number is 109-5970. Clicking the full screen takes one to /images/6893-4adee14aa4422956a1cc23870201201e/info.json whereas inspecting the html shows it should be going to /images/6884-2b97cdf52f290efcacadc3137b7f6d99/info.json.

I set up an embedded item widget in a test exhibit. Full screen brings up the right image. When I embed two different item widgets, the second one's full screen does not seem to work, and clicking on the first item's full screen shows the code throws an error (which seems to come from OpenSeadragon) in the console, although the full screen image is still displayed. Error: "Uncaught DOMException: Node.removeChild: The node to be removed is not a child of this node" and "Uncaught (in promise) TypeError: Fullscreen request denied"

hudajkhan commented 1 year ago

Scrolling further down the page, clicking full screen on the first image seems to be bringing up the image later down the page entitled "Photographer unknown. Workers at Pacific Mills Print Works, ca. 1910."

chrisrlc commented 1 year ago

Related to https://github.com/cul-it/exhibits-library-cornell-edu/issues/428

chrisrlc commented 1 year ago

This is fixed on prod now.