cul-it / exhibits-library-cornell-edu

Spotlight
3 stars 2 forks source link

Set up coveralls #61

Open starsplatter opened 7 years ago

cappadona commented 7 years ago
cappadona commented 7 years ago

Deployed to dev.

JesiBuell79 commented 1 year ago

@chrisrlc done? What does coveralls do? Still needed?

chrisrlc commented 1 year ago

@JesiBuell79 Coveralls generates a code coverage report that shows how much of your code is actually covered by automatic tests. It looks like we have this set up for spotlight, but our billing info for coveralls expired in early 2020... That said, I'd prefer to use consistent tooling across our apps where possible, so I'm going to do some digging to figure out what code coverage tool other apps use.

JesiBuell79 commented 1 year ago

@chrisrlc - Great thank you - and yes, I agree in terms of consistency!

philiprobinson commented 1 year ago

Hi Christina and Jesi, Jim Reidy might have some background on Coveralls. Glad to support uniform tooling if we need to renew the license.

Philip Robinson Director of Software Development Cornell University Library (607) 255-0098 www.library.cornell.edu


From: JesiBuell79 @.> Sent: Thursday, February 23, 2023 4:39:09 AM To: cul-it/exhibits-library-cornell-edu @.> Cc: Subscribed @.***> Subject: Re: [cul-it/exhibits-library-cornell-edu] Set up coveralls (#61)

@chrisrlchttps://github.com/chrisrlc - Great thank you - and yes, I agree in terms of consistency!

— Reply to this email directly, view it on GitHubhttps://github.com/cul-it/exhibits-library-cornell-edu/issues/61#issuecomment-1440836779, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYN6JLL5HYAGYZPTXCG5TWY2BP3ANCNFSM4DCF3BEQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

chrisrlc commented 1 year ago

Thanks @philiprobinson! I talked to Jim a couple days ago to find out what d&a and dcp are using. Sounds like they're trying to use simplecov, but they need cleanup. He's got a ticket for the upcoming sprint to fix code coverage setup for DCP that I'm keeping an eye on in case we can replicate for exhibits/spotlight.