search

cullophid / date-fp

Functional programming date manipulation library
121 stars 17 forks source link

Version 2.0 #20

Closed cullophid closed 8 years ago

cullophid commented 8 years ago

New parse function. Changed code style to match js standard changed all functions returning errors to return invalid dates of NaN as appropriate

TheLudd commented 8 years ago

Is this introducing https://github.com/feross/standard? Because I thought the point was that you should not need an eslint configuration file.

cullophid commented 8 years ago

@TheLudd Its introducing the standard of js standard :) The only real change is the lack of semi colons. I added it in because i like the style, and wanted to hear what people thought.

I realize that This PR is way too big. I am probably gonna split it up but i wanted to hear what people though first.

TheLudd commented 8 years ago

Splitting up is a good idea.

I like no semi colons as long as there is an automatic checker for the cases where no semicolons cause trouble.

cullophid commented 8 years ago

We have: no-unexpected-multiline: 2 # - Avoid code that looks like two expressions but is actually one :)

cullophid commented 8 years ago

Im gonna run this as 3 separate PR instead