search

cult-of-coders / grapher-react

Provides easy to use React Components that are suitable for grapher package.
https://atmospherejs.com/cultofcoders/grapher-react
39 stars 19 forks source link

errorComponent and loadingComponent options don't allow functions #19

Open olgertse opened 6 years ago

olgertse commented 6 years ago

This makes it impossible to use React functional components in errorComponent or loadingComponent options.

theodorDiaconu commented 6 years ago

@od1k good point.

justbill2020 commented 6 years ago

👍 bumping this... Looks like this was broken when poll option was added...

https://github.com/cult-of-coders/grapher-react/blob/master/lib/checkOptions.js#L9-L10