search

cult-of-coders / grapher-react

Provides easy to use React Components that are suitable for grapher package.
https://atmospherejs.com/cultofcoders/grapher-react
39 stars 19 forks source link

Changing the way isLoading is handled #27

Closed arlen-yu closed 5 years ago

arlen-yu commented 5 years ago

Hi. Right now, it seems the way that isLoading is handled for reactive and non-reactive data is different.

For reactive data, isLoading: true for initial load. If I change the filter, isLoading: true again while data is refetched.

For non-reactive, isLoading: true for initial load. If I refetch, isLoading: false even when data is being refetched.

Is this intended, or should isLoading be set to true while non-react data is refetching? I think I see where in the code this is handled, so I'd be happy to submit a pull request implementing this.

theodorDiaconu commented 5 years ago

Released 0.1.3 sorry for delay.